Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/144 Timeout while trying to contact RemoteTestNG #164

Closed
wants to merge 6 commits into from
Closed

Issue/144 Timeout while trying to contact RemoteTestNG #164

wants to merge 6 commits into from

Conversation

missedone
Copy link
Collaborator

this is to fix issue #144 by polling the connection with several retries (default as 360, aka. the total wait time is 5 sec (timeout) * 360 = 1800 sec = 30 min)

max retries is configurable on the man launch tab:
max retries

this also fix the issue #155
for example, add breakpoint at java.util.Properties, you can see the job is running wait for connection, rather than report timeout error and exit:
job

here is the log we can see it's polling (in eclipse log):

!ENTRY org.testng.eclipse 1 0 2015-08-16 04:19:28.968
!MESSAGE TestNG viewer connect timeout, will retry 3, max retries 360

!ENTRY org.testng.eclipse 1 0 2015-08-16 04:19:33.969
!MESSAGE TestNG viewer connect timeout, will retry 4, max retries 360

!ENTRY org.testng.eclipse 1 0 2015-08-16 04:19:38.975
!MESSAGE TestNG viewer connect timeout, will retry 5, max retries 360

!ENTRY org.testng.eclipse 1 0 2015-08-16 04:19:43.977
!MESSAGE TestNG viewer connect timeout, will retry 6, max retries 360

!ENTRY org.testng.eclipse 1 0 2015-08-16 04:19:48.981
!MESSAGE TestNG viewer connect timeout, will retry 7, max retries 360

!ENTRY org.testng.eclipse 1 0 2015-08-16 04:19:53.984
!MESSAGE TestNG viewer connect timeout, will retry 8, max retries 360

@@ -61,7 +61,9 @@ private static String make(String s) {
public static final String GROUP_CLASS_LIST = make("GROUP_LIST_CLASS");

public static final int DEFAULT_LOG_LEVEL = 2;


public static final int DEFAULT_CONNECT_RETRIES = 360;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default max retries as 360, so that the total wait time is 5 sec * 360 = 1800 sec (where 5 sec is the default socket timeout)

@missedone
Copy link
Collaborator Author

i'd like to close this pr as it's based on my wrong understanding of how messafesender work. (though it works so far so good)
will try other option later

@missedone missedone closed this Aug 17, 2015
@missedone missedone deleted the issue/144 branch October 2, 2015 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants