Fix issue 70: isTest looks at superclass methods #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aledsage
commented
Sep 11, 2013
aledsage
commented
- classes with superclasses with test methods now detected as tests
|
Fix for #70 |
|
Ah, I just found |
|
I've refactored to use |
|
@aledsafe let's revisit this PR, do you still have issue #70 with latest vesion of testng eclipse plugin. if so, could you update this PR so that we can have a look then |
Classes with superclasses with test methods now detected as tests
aledsage
force-pushed
the
fix/issue70-infer-test-from-superclass
branch
from
72be17d
to
6c499b8
Compare
|
@missedone Thanks for looking at this! I confirmed this issue #70 was still an issue on master, and have re-applied my changes again master. PR is again ready for review. |
| } | ||
|
|
||
| private static boolean doIsTest(IType iType) { | ||
| ITestContent testContent = TypeParser.parseType(iType); |
There was a problem hiding this comment.
let's have a check if iType is abstract or not at the beginning of this method:
if (Flags.isAbstract(iType.getFlags())) {
return false;
}
|
Thanks @missedone - added check for |
missedone
added a commit
that referenced
this pull request
Dec 29, 2015
…rclass Fix issue 70: isTest looks at superclass methods
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.