-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract sources into modules #777
Comments
I think the idea is good but will be a big change. And we can still have an aggregated artifact which will keep the current behavior. |
Not sure there is a big upside for users there... |
@cbeust
so my initial solution for this is to make the RemoteTestNG of Eclipse Plugin consistent (or compatible) with the RemoteTestNG of Runtime TestNG. to achieve this
i prefer option-2, since with this approach:
if you agree to modularize RemoteTestNG, naturally, we can think about the possibility of modularizing whole TestNG project, as i remember SnakeYaml also introduced some version conflict trouble to the users before, though modularizing does not solve the version conflict at all, but at least reduce the possibility since i believe most of the people won't this testng yaml features too much (just my personal guess:() |
Before digging into this, couldn’t we simply add the missing Cédric |
well, we can add the missing serialVersionUUID to current master branch, but we can't change the already released testng, right? so i doubt that if only add the serialVersionUUID at one side (aka, plugin side), we will still get the InvalidClassException. |
@cbeust What do you think to have a "next" branch for more aggressive refactoring and planned to be released once ready for TestNG 7.0? And keep the current master with quick bug fixes? |
@juherr - Now that TestNG is actually split into multiple modules, can we consider closing this issue ? |
I think we can go further but we can close this issue :) |
From @missedone on testng-team/testng-eclipse#91
The text was updated successfully, but these errors were encountered: