Assure thread affinity

[krmahadevan]

Closes #89, #1050, #1066, #1173, #1185

This PR aims at assuring that methods that fall
under the below two use cases, all run on the
same thread when classes are being run in parallel:

• @test methods in a class are ordered by priority
• @test methods have a single dependency on
  another method using “dependsOnMethods” attribute.

The thread affinity feature is supposed to be
“experimental” and it can be turned on via the
JVM argument : -Dtestng.thread.affinity=true

This feature is turned off by default just to
ensure that we don’t have any users experiencing
un-usual behavior.

Fixes #89, #1050, #1066, #1173, #1185

Did you remember to?

• Add test case(s)
• Update CHANGES.txt

We encourage pull requests that:

• Add new features to TestNG (or)
• Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

[krmahadevan]

@juherr @cbeust - I have tried to implement the approach that I called out #1773 (comment)

[krmahadevan]

@juherr @cbeust - Any idea why Travis CI build doesn't show up on this PR ?

[juherr]

LGTM if all tests pass

[juherr]

IMO we don't need default method here because it is located into the internal package

[juherr]

No idea why Travis is not working for this specific PR.

[krmahadevan]

Here's the build results for this branch from my fork : https://travis-ci.org/krmahadevan/testng/builds/378773133

[dr29bart]

The PR worth a minor release at least

[krmahadevan]

@dr29bart - Can you please quickly check if the fix works using TestNG 7.0.0-SNAPSHOT ?
Please remember to use the JVM argument -Dtestng.thread.affinity=true

[ryudice]

hi, Is there someway I can test this without having to compile testng myself and without waiting for a new release? Like a development maven feed

[krmahadevan]

@cbeust - Snapshots aren't being updated to maven snapshot repository. Can you please help take a look ? https://oss.sonatype.org/content/repositories/snapshots/org/testng/testng/7.0.0-SNAPSHOT/

[robinbobin25]

Hello! Is there any chance it will be released soon?
Thanks

[juherr]

@robinbobin25 Not planned yet but you can follow #1862

[balrajHostAnalytics]

@krmahadevan is -Dtestng.thread.affinity=true fix also covers testng "timeout" with single thread.

[krmahadevan]

Nope. I dont think its related to "timeout". Its mainly to force dependent methods to run on the same thread as their upstream methods. But if you are asking what happens when I add a "timeout" attribute to an "@test" method that depends on an upstream method, run with parallelism enabled and with the JVM argument set as "-Dtestng.thread.affinity=true", that I am not sure. I believe the "timeout" is always a special case, because TestNG always runs methods that have "timeout" attributes in a separate thread instead of the current one. So this JVM flag may not hold true for these sort of methods. But no harm in quickly trying out. Can you please help try it out quickly and post back your findings ?

[jacksonwen001]

Hi all, Any updates? Does it works? 7.0.0 version?

[krmahadevan]

@jacksonwen001 - What updates are you expecting? The latest released version of TestNG is 7.4.0. Can you please be explicit in terms of what is NOT working (if you are having a problem with this feature) ?