Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed only needed dependencies #2358

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Exposed only needed dependencies #2358

merged 1 commit into from
Aug 26, 2020

Conversation

slawekjaranowski
Copy link
Contributor

Additional dependencies will be exposed as gradle feature or maven optional.

Fixes #2357

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt

We encourage pull requests that:

  • Fix bugs in TestNG

Additional dependencies will be exposed as gradle feature or maven optional.

fix: #2357
@krmahadevan
Copy link
Member

@slawekjaranowski - We seem to be having tests failing. Can you please quickly take a look ?

@slawekjaranowski
Copy link
Contributor Author

locally on macOS
./gradlew clean build test pass successful

also on Travis is ok
https://travis-ci.com/github/slawekjaranowski/testng/builds/180806680

I must investigate what happened on GH action, maybe someone can help ...

Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when CI will be ok

@slawekjaranowski
Copy link
Contributor Author

Can you rerun build for master branch in new build I see in logs:
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8

i suspect that this break test.ant.AntTest

@slawekjaranowski
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestNG 7.3.0 transitive dependencies
3 participants