Allow OnAfterClass listeners to run after AfterClass Configuration Methods #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter @afterclass configuration methods. Closes testng-team#2796
juherr
approved these changes
Jan 7, 2023
krmahadevan
approved these changes
Jan 8, 2023
|
@oliver-hughes - Thank You so much for taking the time to help raise a PR to fix this issue. The PR stands merged and will be available in the upcoming release of TestNG. Looking forward to more such contributions. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2796
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.
Code change & Tests to allow specifying ordering of @afterclass and onAfterClass methods to be same as current or symmetrical to @beforeClass and onBeforeClass
I've left current behaviour as default to avoid breaking existing usage.