Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bobshie beforeconfig skip #2881

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

bobshie
Copy link
Contributor

@bobshie bobshie commented Mar 11, 2023

Fixes #2880 .

Did you remember to?

  • [*] Add test case(s)
  • [*] Update CHANGES.txt
  • [*] Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

Signed-off-by: Bob Shi <bob.shi@ericsson.com>
Signed-off-by: Bob Shi <bob.shi@ericsson.com>
Signed-off-by: Bob Shi <bob.shi@ericsson.com>
Copy link
Member

@krmahadevan krmahadevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have shared some comments

Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm once approved by @krmahadevan

@Hkh9966
Copy link

Hkh9966 commented Mar 13, 2023

image
@krmahadevan One UT failed, but it doesn't seem to be related to this change. Can we skip it or relaunch UT again?

Signed-off-by: Bob Shi <bob.shi@ericsson.com>
@krmahadevan krmahadevan merged commit 8b5f4d1 into testng-team:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

before configuration and before invocation should be 'SKIP' when beforeMethod is 'skip'
4 participants