Favour FutureTask for concurrency support #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This implementation will help us eventually fix #2019 and provide a global thread pool for test execution. I will create a PR for that changeset once this is merged. |
|
Hi @juherr - Please let me know if you got a chance to take a look at this PR. |
juherr
approved these changes
Dec 17, 2023
TestNG currently has a custom implementation of ThreadPoolExecutor named GraphThreadPoolExecutor. This class was created to facilitate concurrency in a DAG. Now that we are on JDK11, we can very well move over to leveraging FutureTask based implementations and thus decouple ourselves from the Executor and just focus on orchestrating the next node retrieval for execution. Since this is experimental, we are currently providing a JVM based switch that can fall back to the old Behaviour in case of any issues. JVM argument to use “-Dtestng.favor.custom.thread-pool.executor=true”
krmahadevan
force-pushed
the
move_away_from_gtpexecutor_using_futuretasks
branch
from
8c6d931
to
043b675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestNG currently has a custom implementation of
ThreadPoolExecutor named GraphThreadPoolExecutor.
This class was created to facilitate concurrency
in a DAG.
Now that we are on JDK11, we can very well move
over to leveraging FutureTask based implementations and thus decouple ourselves from the Executor
and just focus on orchestrating the next node retrieval for execution.
Since this is experimental, we are currently providing a JVM based switch that can fall back to the old
Behaviour in case of any issues.
JVM argument to use “-Dtestng.favor.custom.thread-pool.executor=true”