fix: Video not playing on Android 7.0 or earlier #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PruthiviRaj27
commented
Aug 1, 2024
•
PruthiviRaj27
commented
- This PR addresses an issue where videos were not playing correctly on devices running Android 7.0 or earlier. The problem was linked to issues with API calls and SSL/TLS connections on these older versions.
- Lets Encrypt SSL dropped support for older Android devices due to the expiration of cross-signatures. For more details, see Let’s Encrypt Cross-Sign Expiration.
PruthiviRaj27
force-pushed
the
fix_video_not_playing_in_android_7
branch
from
db9483c
to
a357e7a
Compare
PruthiviRaj27
changed the title
Karthik-0
reviewed
Aug 5, 2024
| import javax.net.ssl.TrustManagerFactory | ||
| import javax.net.ssl.X509TrustManager | ||
|
|
||
| class TrustFactory { |
There was a problem hiding this comment.
Add a comment saying let's encrypt dropped support for older android devices with this link https://letsencrypt.org/2023/07/10/cross-sign-expiration
Karthik-0
approved these changes
Aug 5, 2024
PruthiviRaj27
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.