feat: Add Running Content List UI #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthik-0
requested changes
Mar 28, 2023
Comment on lines
36
to
44
| if (loadState is LoadState.Error) { | ||
| if (loadState.error.localizedMessage?.contains("404") == true){ | ||
| binding.emptyTitle.text = "Content Not Found" | ||
| binding.emptyDescription.text = "Content Not Found, Please try after some time" | ||
| } | ||
| } | ||
| binding.progressBar.isVisible = loadState is LoadState.Loading | ||
| binding.retryButton.isVisible = loadState is LoadState.Error | ||
| binding.errorMessageContainer.isVisible = loadState is LoadState.Error |
| container: ViewGroup?, | ||
| savedInstanceState: Bundle? | ||
| ): View? { | ||
| parseArguments() |
| savedInstanceState: Bundle? | ||
| ): View? { | ||
| parseArguments() | ||
| initializeViewModel() |
Comment on lines
74
to
80
| private fun bindViews() { | ||
| binding.apply { | ||
| this@RunningContentListFragment.recyclerView = binding.recyclerView | ||
| this@RunningContentListFragment.emptyContainer = binding.errorContainer | ||
| } | ||
| } | ||
|
|
Comment on lines
112
to
130
| private fun bindListView() { | ||
| binding.apply { | ||
| lifecycleScope.launchWhenCreated { | ||
| adapter.loadStateFlow.collect { | ||
| val notLoading = it.refresh is LoadState.NotLoading | ||
| val loading = it.refresh is LoadState.Loading | ||
| val error = it.refresh is LoadState.Error | ||
| val isItemCountZero = adapter.itemCount == 0 | ||
|
|
||
| shimmerViewContainer.isVisible = loading | ||
| recyclerView.isVisible = (notLoading || error) && adapter.itemCount != 0 | ||
| showEmptyOrErrorMessage( | ||
| notLoading && isItemCountZero, | ||
| error && isItemCountZero | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| } |
Karthik-0
requested changes
Mar 28, 2023
Comment on lines
38
to
62
| try { | ||
| page = when (loadType) { | ||
| LoadType.REFRESH -> DEFAULT_PAGE_INDEX | ||
| LoadType.PREPEND -> return MediatorResult.Success(endOfPaginationReached = true) | ||
| LoadType.APPEND -> { | ||
| val remoteKeys = getRemoteKeyForLastItem(state) | ||
| val nextKey = remoteKeys?.nextKey | ||
| ?: return MediatorResult.Success(endOfPaginationReached = remoteKeys != null) | ||
| nextKey | ||
| } | ||
| } | ||
|
|
||
| val apiResponse = fetchRunningContents(page) | ||
| val result = apiResponse.results | ||
| endOfPaginationReached = (apiResponse.next == null) | ||
|
|
||
| storeDataInDB(loadType,result) | ||
|
|
||
| return MediatorResult.Success(endOfPaginationReached = endOfPaginationReached) | ||
| } catch (e: IOException) { | ||
| return MediatorResult.Error(e) | ||
| } catch (e: HttpException) { | ||
| return MediatorResult.Error(e) | ||
| } | ||
| } |
Karthik-0
reviewed
Mar 28, 2023
| if (content != null) { | ||
| val domainContent = content.asDomainContent() | ||
| holder.bind(domainContent) { onItemClick(domainContent, holder.itemView.context) } | ||
| holder.setDateAndVisiblity( |
There was a problem hiding this comment.
This name itself is confusing. If I am going to set a date then obviously it should be visible.
Karthik-0
reviewed
Mar 28, 2023
Comment on lines
39
to
46
| pageNumber = when (loadType) { | ||
| LoadType.REFRESH -> DEFAULT_PAGE_INDEX | ||
| LoadType.PREPEND -> return MediatorResult.Success(endOfPaginationReached = true) | ||
| LoadType.APPEND -> { | ||
| getNextPageNumber(state) | ||
| ?: return MediatorResult.Success(endOfPaginationReached = true) | ||
| } | ||
| } |
There was a problem hiding this comment.
This can be extracted to separate method. Let it return -1 for prepend or no next page
Karthik-0
reviewed
Mar 28, 2023
|
|
||
| storeDataInDB(loadType,apiResponse.results) | ||
|
|
||
| return MediatorResult.Success(endOfPaginationReached = endOfPaginationReached) |
There was a problem hiding this comment.
Suggested change
| return MediatorResult.Success(endOfPaginationReached = endOfPaginationReached) | |
| return MediatorResult.Success(endOfPaginationReached = (apiResponse.next == null)) |
Karthik-0
requested changes
Mar 28, 2023
Comment on lines
+18
to
+28
| private fun getCurrentMonthMills(): Long { | ||
| val calendar = Calendar.getInstance() | ||
| val daysInCurrentMonth = calendar.getActualMaximum(Calendar.DAY_OF_MONTH) | ||
| return TimeUnit.DAYS.toMillis(daysInCurrentMonth.toLong()) | ||
| } | ||
|
|
||
| private fun getCurrentYearMills(): Long { | ||
| val calendar = Calendar.getInstance() | ||
| val daysInCurrentYear = calendar.getActualMaximum(Calendar.DAY_OF_YEAR) | ||
| return TimeUnit.DAYS.toMillis(daysInCurrentYear.toLong()) | ||
| } |
Karthik-0
reviewed
Mar 29, 2023
| } | ||
| } | ||
|
|
||
| private fun updateListView() { |
Karthik-0
reviewed
Mar 29, 2023
| @@ -33,4 +52,50 @@ object DateUtils { | |||
|
|
|||
| return seconds | |||
| } | |||
|
|
|||
| fun getHumanizedTimeDifferenceOrEmpty(startTimeOrEndTime: String?, context: Context): String { | |||
There was a problem hiding this comment.
Suggested change
| fun getHumanizedTimeDifferenceOrEmpty(startTimeOrEndTime: String?, context: Context): String { | |
| fun getRelativeTimeString(startTimeOrEndTime: String?, context: Context): String { |
Karthik-0
reviewed
Mar 30, 2023
| super.onViewCreated(view, savedInstanceState) | ||
| initializeListView() | ||
| initializeListeners() | ||
| observeAdapterLoadingStateAndUpdateUI() |
There was a problem hiding this comment.
Suggested change
| observeAdapterLoadingStateAndUpdateUI() | |
| showLoadingOrContentsList() |
Karthik-0
reviewed
Mar 30, 2023
course/src/main/java/in/testpress/course/adapter/BaseContentListAdapter.kt
Show resolved
Hide resolved
Karthik-0
reviewed
Mar 30, 2023
Comment on lines
55
to
56
| setDate(content) | ||
| setDateVisiblity(content) |
There was a problem hiding this comment.
Let these derived view holder override bind and display these. By default date should not be visible and if needed then viewholder will derive and display it.
Don't use set in method name in derived class
bharathwaaj
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done