Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change selectReader to use total function #29

Closed
enlait opened this issue Jul 24, 2018 · 0 comments
Closed

Change selectReader to use total function #29

enlait opened this issue Jul 24, 2018 · 0 comments
Assignees
Milestone

Comments

@enlait
Copy link

enlait commented Jul 24, 2018

We use -Xfatal-warnings + -Xlint:unsound-match, which is good for preventing runtime MatchErrors on incomplete matches on sealed subtypes.

However, selectReader accepts a partial function.

  1. "partial" property is not used withing the code, PF is just applied to receive a reader
  2. total function heuristics for emitting warnings are not applied to selectReader argument

I think that partial argument, even if implemented to actually be useful for something, shouldn't be the default.

@eld0727 eld0727 self-assigned this Sep 3, 2018
@eld0727 eld0727 added this to the v0.7.0 milestone Sep 3, 2018
eld0727 added a commit that referenced this issue Sep 3, 2018
@eld0727 eld0727 closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants