-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds homebrew bump automation #18
Conversation
This helps us complete patch releases since Envoy aren't actually doing it, yet. See envoyproxy/envoy#17500 Signed-off-by: Adrian Cole <adrian@tetrate.io>
✔️ Deploy Preview for archive-envoy ready! 🔨 Explore the source changes: 7309801 🔍 Inspect the deploy log: https://app.netlify.com/sites/archive-envoy/deploys/6125b9066ba45f0008b61ba1 😎 Browse the preview: https://deploy-preview-18--archive-envoy.netlify.app |
Signed-off-by: Adrian Cole <adrian@tetrate.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome💯
uses: mislav/bump-homebrew-formula-action@v1 | ||
with: | ||
formula-name: ${{ github.event.inputs.formula }} | ||
tag-name: ${{ github.event.inputs.tag-name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to add this below here:
download-url: https://github.com/envoyproxy/envoy/archive/${{ github.event.inputs.tag-name }}.tar.gz
This won't work until either the automation can handle git tags or envoy's formula doesn't rely on git. Thanks to @cho-m for troubleshooting Homebrew/homebrew-core#83921 (comment) Here's the change needed to the envoy formula (using revision instead of a tag.gz sha)
|
You might want to try https://github.com/dawidd6/action-homebrew-bump-formula -- I think this one doesn't choke on formulae that use Git tags + revisions. |
Thanks, I will switch it and use it next time (next month I suppose would be when another round of patches land) |
https://github.com/marketplace/actions/homebrew-bump-formula as also mentioned, which maybe the same as the prior! |
This helps us complete patch releases since Envoy aren't actually doing
it, yet.
See envoyproxy/envoy#17500