Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds homebrew bump automation #18

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Adds homebrew bump automation #18

merged 2 commits into from
Aug 25, 2021

Conversation

codefromthecrypt
Copy link
Contributor

This helps us complete patch releases since Envoy aren't actually doing
it, yet.

See envoyproxy/envoy#17500

This helps us complete patch releases since Envoy aren't actually doing
it, yet.

See envoyproxy/envoy#17500

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@netlify
Copy link

netlify bot commented Aug 25, 2021

✔️ Deploy Preview for archive-envoy ready!

🔨 Explore the source changes: 7309801

🔍 Inspect the deploy log: https://app.netlify.com/sites/archive-envoy/deploys/6125b9066ba45f0008b61ba1

😎 Browse the preview: https://deploy-preview-18--archive-envoy.netlify.app

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome💯

@codefromthecrypt codefromthecrypt merged commit 52a12f9 into master Aug 25, 2021
@codefromthecrypt codefromthecrypt deleted the homebrew-flow branch August 25, 2021 03:48
uses: mislav/bump-homebrew-formula-action@v1
with:
formula-name: ${{ github.event.inputs.formula }}
tag-name: ${{ github.event.inputs.tag-name }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to add this below here:

          download-url: https://github.com/envoyproxy/envoy/archive/${{ github.event.inputs.tag-name }}.tar.gz

@codefromthecrypt
Copy link
Contributor Author

This won't work until either the automation can handle git tags or envoy's formula doesn't rely on git.

Thanks to @cho-m for troubleshooting

Homebrew/homebrew-core#83921 (comment)

Here's the change needed to the envoy formula (using revision instead of a tag.gz sha)

  # TODO: We can't use the tar.gz archive URL, which means bump-homebrew-formula-action doesn't work. See #83921
  url "https://github.com/envoyproxy/envoy.git",
     tag:      "v1.19.1",
     revision: "a2a1e3eed4214a38608ec223859fcfa8fb679b14"

@carlocab
Copy link

You might want to try https://github.com/dawidd6/action-homebrew-bump-formula -- I think this one doesn't choke on formulae that use Git tags + revisions.

@codefromthecrypt
Copy link
Contributor Author

Thanks, I will switch it and use it next time (next month I suppose would be when another round of patches land)

@codefromthecrypt
Copy link
Contributor Author

https://github.com/marketplace/actions/homebrew-bump-formula as also mentioned, which maybe the same as the prior!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants