Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support-and-testing for ubuntu-18.04, add ubuntu-22.04 #46

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

dio
Copy link
Contributor

@dio dio commented Nov 18, 2022

Since 1.24.0, envoy requires a newer glibc:

./envoy: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by ./envoy)
./envoy: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by ./envoy)

Corresponding CI run: https://github.com/tetratelabs/archive-envoy/actions/runs/3500591896/jobs/5863455940.

We could install a newer glibc on /opt and do patchelf but probably too complicated.

Reference: https://github.com/envoyproxy/envoy/blob/1647d3613d4a23467daaf067c906772e17e8bd3a/ci/README.md#build-image-base-and-compiler-versions envoy build image for Linux uses ubuntu-20.04.

This PR removes running tests on ubuntu-18.04 and adds ubuntu-22.04. Consequently, we skip supporting and testing Envoy on platforms before ubuntu-22.04.

Signed-off-by: Dhi Aurrahman dio@rockybars.com

The recent releases of Envoy requires newer glibc:

./envoy: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by ./envoy)
./envoy: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by ./envoy)

https://github.com/tetratelabs/archive-envoy/actions/runs/3500591896/jobs/5863455940.

We can install a newer glibc on /opt and do patchelf but probably too complicated.

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@@ -62,7 +62,6 @@ jobs:
# Non-deprecated from https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
# Note: We don't test arm64 on release as it is unlikely to fail and too much effort.
include:
- os: ubuntu-18.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe switch this to 22.04 and add a trailing comment to the next line like # envoy x.x is the earliest to support this.

Also mention in the PR desc which versions no longer are testable even if it doesn't matter as we only test ones released?

@cpakulski
Copy link
Contributor

If I am not mistaken, it is not only about testing. It basically means that we do not support ubuntu 18.04 any more. An ubuntu 18.04 user gets "linux" image and it fails to execute because of incompatible default libc libraries.

@codefromthecrypt
Copy link
Contributor

@cpakulski agreed. it is about the compatibility of envoy and the platforms. We can't control that, but we can add notes to our GH action about what is convenient to test. In any case it isn't a real test.

my 2p

Ex. put a header comment like this on the matrix, then qualify the versions like I mentioned here for the current status, knowing that later there will be similar maintenance. The matrix in func-e may need similar notes.

# Operating systems in this matrix can run recent versions of Envoy. This
# needs maintenance as Envoy requires newer versions of libc. The point
# of these tests are only to ensure the tarball wasn't corrupted or built
# for the wrong platform.

@codefromthecrypt
Copy link
Contributor

envoy doesn't have a compatibility matrix though it should. that could be fixed, especially as they attach binaries to releases now. maybe there's a better substitute but this could be linked for now until there's proper docs upstream https://github.com/envoyproxy/envoy/blob/1647d3613d4a23467daaf067c906772e17e8bd3a/ci/README.md

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
@dio dio changed the title Disable testing on ubuntu-18.04 Remove support and testing for ubuntu-18.04 Nov 22, 2022
@dio dio changed the title Remove support and testing for ubuntu-18.04 Remove support-and-testing for ubuntu-18.04, add ubuntu 22.04 Nov 22, 2022
@dio dio changed the title Remove support-and-testing for ubuntu-18.04, add ubuntu 22.04 Remove support-and-testing for ubuntu-18.04, add ubuntu-22.04 Nov 22, 2022
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coolio

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
@codefromthecrypt codefromthecrypt merged commit 4eb5caf into tetratelabs:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants