Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support-and-testing for ubuntu-18.04, add ubuntu-22.04 #46

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Remove support-and-testing for ubuntu-18.04, add ubuntu-22.04 #46

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c40e57
Disable testing on ubuntu-18.04
dio Nov 18, 2022
999fa2a
Review comments
dio Nov 22, 2022
27a8097
Add suggestions
dio Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,13 @@ jobs:
matrix:
# Non-deprecated from https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
# Note: We don't test arm64 on release as it is unlikely to fail and too much effort.
#
# Operating systems in this matrix can run recent versions of Envoy. This needs maintenance
# as Envoy requires newer versions of libc. The point of these tests are only to ensure the tarball wasn't corrupted
# or built for the wrong platform.
include:
- os: ubuntu-18.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe switch this to 22.04 and add a trailing comment to the next line like # envoy x.x is the earliest to support this.

Also mention in the PR desc which versions no longer are testable even if it doesn't matter as we only test ones released?

- os: ubuntu-20.04
- os: ubuntu-20.04 # the envoy 1.24.0 is the earliest to support this.
codefromthecrypt marked this conversation as resolved.
Show resolved Hide resolved
- os: ubuntu-22.04
- os: macos-12
- os: windows-2019
- os: windows-2022
Expand Down