-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds api for library usage #434
Conversation
Signed-off-by: Adrian Cole <adrian@tetrate.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added notes on how to proceed
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
protip. we have some infrastructure that allows unit testing w/o remote download deps something like.. homeDir := t.TempDir()
envoyVersion := version.LastKnownEnvoy
versionsServer := test.RequireEnvoyVersionsTestServer(t, envoyVersion)
defer versionsServer.Close()
envoyVersionsURL := versionsServer.URL + "/envoy-versions.json"
out := new(bytes.Buffer)
... now use em |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
looks like the value in https://github.com/tetratelabs/func-e/blob/master/internal/version/last_known_envoy.txt is causing the CI to fail |
seems thing haven't been maintained in a while. I ran the 1.23.1 tag on archive-envoy and then raised this to move to it #435 |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
getting this error on windows
@codefromthecrypt any idea why that might be happening ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some thoughts, noting that windows concerns are a big reason why the e2e directory has some custom runner code, and also that we have things like moreos
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Hey ! |
Hey @mathetake can you ptal ( since @codefromthecrypt is a co-author ) ? |
Since it isn't obvious to everyone why I closed this. Here's why. This repo has no stale bot. Things dead without impact for several months should be closed. Anyone who is motivated and can do a decent job in execution can carry it forward. However, I'm not going to hold that up and have closed all PRs on all repos that have been dead for periods of 6 months or longer. |
This is a sketch. A real impl will need to test things, similar to our e2e test. Particularly there could be some tricky things for example, how to signal close since the envoy run will block the calling thread. This is mainly to show that the api approach should be precise and only expose top-level concepts that relevant to import.
Fixes: #433