Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow downstream projects to import func-e #446

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow downstream projects to import func-e #446

wants to merge 2 commits into from

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Aug 9, 2023

  • Define an api that allows go projects to use func-e as a library

Takes #434 forward

Fixes: #433

@arkodg
Copy link
Contributor Author

arkodg commented Aug 9, 2023

CI is failing due to an unrelated test failing

func-e/lint/last_known_envoy_test.go

Line 37 in 9c44e50

func TestLastKnownEnvoyAvailableOnAllPlatforms(t *testing.T) {

mathetake
mathetake reviewed Aug 9, 2023
View reviewed changes
api/run.go Show resolved Hide resolved
mathetake
mathetake reviewed Aug 9, 2023
View reviewed changes
api/run.go
// Wait for run to exit or an explicit stop.
select {
case <-ctx.Done():
return nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we kill the envoy process in this case? (not sure if there's such function in func-e now)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this done in the called func libs

func-e/internal/envoy/run.go

Line 78 in 82577c9

// At this point, shutdown hooks have run and Envoy is interrupted.
?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool but it seems to me that the code block only reaches when the OS signal was sent. Is there any way to verify that it works as intended? e.g. passing the fake config that runs indefinitely in tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you point me to some tests in the code base that verify this, that I can peruse here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry no idea. Could you do that by yourself ?

@arkodg
Allow downstream projects to import func-e
8b44356 
* Define an api that allows go projects to use func-e as a library

Takes #434 forward

Fixes: #433

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
add another test to improve coverage
6384e98 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake left review comments

@codefromthecrypt codefromthecrypt Awaiting requested review from codefromthecrypt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow downstream projects to programmatically run envoy
2 participants
@arkodg @mathetake