jit: support for memory grow/size #85
Conversation
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
| // Now size should return the new pages -- 10. | ||
| out, _, err = store.CallFunction("test", "size") | ||
| require.NoError(t, err) | ||
| require.Equal(t, newPages, out[0]) |
There was a problem hiding this comment.
I suppose there's no test we can do to see that the memory is usable? (ex using an offset that would only work if it was 10)
There was a problem hiding this comment.
indirectly tested as the size instruction takes len of the memory region, meaning that these offsets can be assumed to work. (Plus memory load,store instructions are not implemented so I cannot write in-Wasm memory access to verify it for now :D)
| builder.initializeReservedRegisters() | ||
| // Emit memory.size instructions. | ||
| builder.handleMemorySize() | ||
| // At this point, the size of memory should be pushed onto the stack. |
There was a problem hiding this comment.
ex this is a good "what" comment because the assertion is a bit indirect. so this one helps a lot
There was a problem hiding this comment.
agreed yeah:D I've put too many comments including the obvious ones. Will keep each line more meaningful from now on!
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
@codefromthecrypt thanks a lot! 🕺 |
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io