copy icons+separators from submenu to toolbar combobox drop-down list #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances copying data from main (sub)menus when the menu is added to a combobox in a toolbar (s. config dialog->Toolbars), and resolves #3025.
Now icons for actions and separators from the menu are copied as well.
Design note: In order to keep the width of the combo box small, no shortcuts are copied. You can find this in the main menu or in the configuration.
Example
Add menu main/tools/commands to the custom toolbar in the config dialog. Now compare the main menu (in the middle) with the added menu as in txs version 4.5.1 (to the left) and in txs build with this PR (to the right):