Fix removing blockquote when ta-default-wrap=br #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I will look at this late today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #1385 due to merge errors.
When blockquote is removed when ta-default-wrap=br, it results in removal of the text. The text is not actually removed, it is inside an opening and closing BR tag which makes the text seem to be removed in some browsers. The opening and closing BR tags are a problem in quite a few places withing textAngular, due to treating BR like a P or DIV element which has opening and closing tags.
This also includes updated tests, for testing blockquote removal when ta-default-wrap=br