Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngFocus provide #47

Closed
wants to merge 3 commits into from
Closed

ngFocus provide #47

wants to merge 3 commits into from

Conversation

nizsheanez
Copy link

In my project i need to show toolbar only when editor is active.
It's mean that use click to editor or focus it by tab on keyboard.

Click to editor easy to implement as ngClick by parrent element, but with ngFocus it's impossible.

@SimeonC
Copy link
Collaborator

SimeonC commented Dec 10, 2013

Hi There. Thanks for the Pull Request. I'll look into getting this merged in but we have another ticket open #42 that this may conflict with. I'll have a think about it.

@ghost ghost assigned SimeonC Dec 11, 2013
@SimeonC
Copy link
Collaborator

SimeonC commented Dec 11, 2013

I've looked through the options and have come up with a solution that fits where we are headed a bit better and is a bit more robust and complete. There will be a commit and new pre-release up soon.

In the update I'm using a combination of ng-focus/ng-blur triggering and adding a custom class to the text-angular parent. This means your use of ng-focus on the text-angular parent will still work for showing the toolbar, but you could also use something in ng-blur to hide the toolbar on loss of focus. Alternately you could use some css like (visible is the default class):

.ta-root .ta-toolbar{
  visibility: hidden;
}
.ta-root.visible .ta-toolbar{
  visibility: visible;
}

@SimeonC SimeonC closed this Dec 11, 2013
@nizsheanez
Copy link
Author

yes, it's cool thanks

SimeonC pushed a commit that referenced this pull request Dec 11, 2013
…ling on focus events. #47

- Updates to fix Angular.JS breaking with parameter renaming minification. #49
- Minor bug fix to disable links from being 'clickable' in the editor.
- Updated the default toolbar to include ALL default tools.
- Update the tools to use activeState better.
- Small update to allow use of ta-bind outside of textAngular.
- Changed the raw html view to use a text-area for better compatability.
@SimeonC
Copy link
Collaborator

SimeonC commented Dec 11, 2013

This has been added in into pre-release 3

netbubu17 pushed a commit to netbubu17/textAngular that referenced this pull request Dec 19, 2013
…ling on focus events. textAngular#47

- Updates to fix Angular.JS breaking with parameter renaming minification. textAngular#49
- Minor bug fix to disable links from being 'clickable' in the editor.
- Updated the default toolbar to include ALL default tools.
- Update the tools to use activeState better.
- Small update to allow use of ta-bind outside of textAngular.
- Changed the raw html view to use a text-area for better compatability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants