New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully Modularised Toolbar #42
Comments
Hello Simeon, Thank you for accepting my feature request. Some years ago I have made the same feature request for the free WPF RichTextBox from Microsoft which is used by the WPF toolkit on codeplex. It got also implemented and the people liked it so they will like your control when you have implemented it :) I really vote for the convenience functions ;-) about the rest I agree. About what UX issues do you speak? |
No I was thinking more around if you use multiple toolbars, say if you wanted editor instances 1 and 2 to have ability to toggle HTML then editors 3 and 4 to only have bold/italics then there is the possibility for user confusion on which toolbar is active for my current editor. As to your second point, as we use contenteditable areas I don't think you can select text in more than one editor at a time (I haven't tested this thou). |
"I don't think you can select text in more than one editor at a time " True just checked it. "...then there is the possibility for user confusion on which toolbar is active for my current editor...." Well I would say I have to operate on the one toolbar placed over the text editor? |
"Well I would say I have to operate on the one toolbar placed over the text editor?" I was getting at this change has the potential to have toolbars placed in funny places relative to editors (for whatever reason). Also even if the toolbars are sensibly placed we'd still want to make a class change to the active toolbar so that the developer can make a visual update via css/js if they want. |
Yes Yes Yes think it throught you can do it man. If you need free beer lemme know ;-) |
How about more time, I could do with that :). In all likely-hood it will take me until Feb 2014 to look into this as I'm on leave very soon. If anyone else does this @fraywing should be able to look into it as a pull request if he gets the time. Otherwise it'll take some time before I start. |
Updated grunt uglifier. Added textAngular-sanitize.js. This is a fork of angular-sanitise.js that specifically allows style attributes ONLY with the colour option, all others will be stripped out. #62 Fixing and testing of Uglified Output #60 Finished Implementation of #42 - there is a deferred promise sequence to the action of the toolbar button now, this allows us to use custom popups in theory. Still need to save and recall the selection manually atm.
Implemented in 1.2.0 branch. |
This is a light spec for the feature requested in #40 and #41.
textAngular as it stands has all the buttons in the toolbar as customisable plugins that the user can change at will. The core issue raised in #40 and #41 is that the toolbar itself cannot be customised so easily.
In short there were 2 requests:
To solve these I think the following needs to be done:
Potential Issues:
Anyone else have any thoughts?
The text was updated successfully, but these errors were encountered: