Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/test_parsing_expressions: more specific assert statements #110

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

stanislaw
Copy link
Contributor

Setting the exact string match expectations helps to visualize what exactly changes with any attempts to refactor the error reporting functionality.

Code review checklist

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated

Doesn't seem to be applicable:

  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
    to update for typo fixes and such).

Setting the exact string match expectations helps to visualize what exactly
changes with any attempts to refactor the error reporting functionality.
@igordejanovic
Copy link
Member

Looks good.

@igordejanovic igordejanovic merged commit 7523102 into textX:master Apr 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants