tests/test_parsing_expressions: fix specific assert statements #111
+23
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I apologize for the fast coding yesterday. I marked with "FIXME" some of the tests incorrectly.
| @@ -201,18 +199,17 @@ def grammar(): | |||
| "Expected 'b' at position (1, 7) => 'a, c, *'." | |||
| ) == str(e.value) | |||
|
|
|||
| # FIXME: This looks strange. Shouldn't be ',' at position 6? | |||
| with pytest.raises(NoMatch): | |||
| # FIXME: Shouldn't the ',' be at position 5? | |||
There was a problem hiding this comment.
I think that the position is good as , should be found instead of c (at the position of c) and the column number is one-based.
|
No problem. I missed those during the review also. There is one comment above but I'm nevertheless merging this change as we can work out comments in later iterations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for the fast coding yesterday. I marked with "FIXME" some of the tests incorrectly.
Code review checklist
Doesn't seem to be applicable:
CHANGELOG.md, no needto update for typo fixes and such).