Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly decode VERSIONFILE as UTF-8 #86

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Explicitly decode VERSIONFILE as UTF-8 #86

merged 1 commit into from
Nov 26, 2020

Conversation

neirbowj
Copy link
Contributor

Fixes #85

Code review checklist

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
    to update for typo fixes and such).

@igordejanovic
Copy link
Member

@neirbowj Thanks

@igordejanovic igordejanovic merged commit 0918d70 into textX:master Nov 26, 2020
@neirbowj neirbowj deleted the explicit_encoding branch November 26, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.py fails with UnicodeDecodeError
2 participants