Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aiohttp.get deprecated #12

Closed
Artimi opened this issue Apr 24, 2017 · 3 comments
Closed

Aiohttp.get deprecated #12

Artimi opened this issue Apr 24, 2017 · 3 comments

Comments

@Artimi
Copy link

Artimi commented Apr 24, 2017

Hello,
I've encountered a problem with aslack and aiohttp. Aiohttp deprecated aiohttp.get() function aio-libs/aiohttp#729 in version 0.21 which is used in aslack https://github.com/textbook/aslack/blob/master/aslack/slack_api.py#L192. Problem is that in setup.py the aiohttp is constrained only to be >=0.15.0 https://github.com/textbook/aslack/blob/master/setup.py#L59 . I hotfixed this in production by pinning aiohttp to version 0.20.0, because I don't use it anywhere else in the program. Please update setup.py or better update your code to be able to have recent aiohttp.

@textbook
Copy link
Owner

Thanks for letting me know; I'll push a quick fix to pin the dependency, then look into adopting the session approach, as it seems like that's going to be more efficient.

@textbook
Copy link
Owner

v0.11.0 pins the dependency: https://github.com/textbook/aslack/blob/v0.11.0/setup.py#L59

@Artimi
Copy link
Author

Artimi commented Apr 25, 2017

Thanks for fast fix!

@textbook textbook closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants