Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recompiling of nodes created with TexText < 0.5 fails #15

Closed
jcwinkler opened this issue Apr 6, 2018 · 2 comments
Closed

Recompiling of nodes created with TexText < 0.5 fails #15

jcwinkler opened this issue Apr 6, 2018 · 2 comments
Assignees
@jcwinkler

Comments

@jcwinkler
Copy link
Member

When editing nodes created with TexText < 0.5 the following error is thrown:

TypeError: unsupported operand type(s) for *=: 'NoneType' and 'float'

Reason: These nodes do not have the scale attribute. Hence, the following code fails, since current_scale is None (returned by TexText.get_old()):

current_scale *= self.uutounit(1, "pt")

Possible fix: Let TexText.get_old() return 1.0 instead of None for the default scale factor.
@jcwinkler jcwinkler added the bug Something isn't working label Apr 6, 2018
@jcwinkler jcwinkler self-assigned this Apr 6, 2018
jcwinkler added a commit to jcwinkler/textext that referenced this issue May 4, 2018
@jcwinkler
Applied patch for issue textext#15
c55d578 
(Actually, this patch is not directly related to the topic of the branch
but I need it for proper testing of old nodes)
@jcwinkler jcwinkler mentioned this issue May 8, 2018
Merged
jcwinkler added a commit to jcwinkler/textext that referenced this issue May 12, 2018
@jcwinkler
Applied patch for issue textext#15
ff401ea 
(Actually, this patch is not directly related to the topic of the branch
but I need it for proper testing of old nodes)
@jcwinkler jcwinkler mentioned this issue May 13, 2018
Closed
jcwinkler added a commit that referenced this issue May 13, 2018
@jcwinkler
Applied patch for issue #15
acaad4f 
(Actually, this patch is not directly related to the topic of the branch
but I need it for proper testing of old nodes)

(cherry picked from commit c55d578)
@jcwinkler
Copy link
Member Author

Hotfix for TexText 0.7.2

Download link for fixed textext.py to replace installed file from version 0.7.2: textext.py

@jcwinkler jcwinkler added Workaround available This is essentially a bug but a workaround is available which might be used until a fix is provided. and removed Workaround available This is essentially a bug but a workaround is available which might be used until a fix is provided. bug Something isn't working labels May 13, 2018
@jcwinkler
Copy link
Member Author

Fixed in release 0.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcwinkler jcwinkler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcwinkler