Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various exceptions that appeared when moving from 2.2.2 to 2.3.11 #44

Merged
merged 9 commits into from
Jun 3, 2017

Conversation

adam-iris
Copy link

These are all based on content that parsed successfully (not necessarily correctly, but without raising exceptions) in version 2.2.2, but caused problems when we moved to 2.3.11. (See the added test cases for examples of the content that was failing -- this also addresses the Unicode exception in #43, although I neglected to add a test case for that.)

I used the PHP Textile code as a guideline for these, in a lot of cases the PHP code relies on behavior that's different from Python (for example, trying to pop an item off an empty list apparently returns a null item in PHP, but raises an exception in Python). I tried to handle these in a minimal way so that the structure of the code doesn't deviate too far from the PHP version.

The one test case I'm a bit unsure about is the first one in test_urls.py -- if the link text starts with a space, the behavior is a bit unexpected (it quotes the whole line up to the link) but this matches the behavior of the PHP version.

@codecov-io
Copy link

codecov-io commented Jun 2, 2017

Codecov Report

Merging #44 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #44   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           12     12           
  Lines         1203   1206    +3     
  Branches       213    213           
======================================
+ Hits          1203   1206    +3
Impacted Files Coverage Δ
textile/objects/block.py 100% <ø> (ø) ⬆️
textile/core.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a6a02...deca51e. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 2, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 21b60a3 on adam-iris:regressions into 11397f2 on textile:master.

@ikirudennis ikirudennis changed the base branch from master to develop June 3, 2017 15:55
@ikirudennis
Copy link
Member

Thanks so much for this, @adam-iris.

@coveralls
Copy link

coveralls commented Jun 3, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling deca51e on adam-iris:regressions into a8a6a02 on textile:develop.

@ikirudennis ikirudennis merged commit da00f08 into textile:develop Jun 3, 2017
@adam-iris
Copy link
Author

Thanks for the quick integration and release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants