add a HTTP header to hint the server only the car header is needed #21
Conversation
| @@ -134,11 +134,14 @@ func (u *HTTPURI) String() string { | |||
| return u.uri | |||
| } | |||
|
|
|||
| func (u *HTTPURI) getRequest(ctx context.Context) (*http.Response, error) { | |||
| func (u *HTTPURI) getRequest(ctx context.Context, extraHeaders ...headerModifier) (*http.Response, error) { | |||
There was a problem hiding this comment.
A bit overkill - just want to allow callers passing header optionally.
There was a problem hiding this comment.
SGTM. This allows not only adding but mostly doing anything; eventually we can pas a map and simply add things to avoid one things to mess up with another (and possible the order in which things are applied; responsibility of the caller anyway).
This is a private method anyway, so not a big deal. SGTM.
Signed-off-by: Merlin Ran <merlinran@gmail.com>
merlinran
force-pushed
the
merlin/car-header-only
branch
from
79b5e57
to
ca9ad19
Compare
| @@ -134,11 +134,14 @@ func (u *HTTPURI) String() string { | |||
| return u.uri | |||
| } | |||
|
|
|||
| func (u *HTTPURI) getRequest(ctx context.Context) (*http.Response, error) { | |||
| func (u *HTTPURI) getRequest(ctx context.Context, extraHeaders ...headerModifier) (*http.Response, error) { | |||
There was a problem hiding this comment.
SGTM. This allows not only adding but mostly doing anything; eventually we can pas a map and simply add things to avoid one things to mess up with another (and possible the order in which things are applied; responsibility of the caller anyway).
This is a private method anyway, so not a big deal. SGTM.
No description provided.