Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

textile comments add from tour doc #795

Closed
doodlemania2 opened this issue May 28, 2019 · 1 comment · Fixed by #821
Closed

textile comments add from tour doc #795

doodlemania2 opened this issue May 28, 2019 · 1 comment · Fixed by #821
Labels
bug Something isn't working

Comments

@doodlemania2
Copy link

Describe the bug
Attempting to perform: https://docs.textile.io/a-tour-of-textile/#add-a-comment causes the error "unknown long flag "--block" - looks like it is position valued now, not variable set

To Reproduce
Steps to reproduce the behavior:

Create a thread
Add a file
Invite a peer
LS the blocks to check
Execute: similar to textile comments add "Is this an outlier?" --block="QmUvWjstQzR6y7UctRJgVjcKsKzutZoiBsQw6WBXMnmg84"

Expected behavior
Comment to be added
IF, I do it positionally: textile comments add "blockid" "my comment" it returns successfully but with an empty array, also, comment not appearing.

Additional context
v0.2.2

@doodlemania2 doodlemania2 added the bug Something isn't working label May 28, 2019
@doodlemania2
Copy link
Author

Similar error happening on LIKE (step below)

balupton added a commit that referenced this issue Jun 13, 2019
- Closes textileio/community#89
- Closes #783
- Closes #793
- Closes #794
- Closes #795
- Closes #797
- Closes #798
- Closes #799
- Closes #809
- Closes #812

## Internal changes:

- next page functionality moved to helper, and wording changed to be more clear

## User facing changes:

- Removed the concept of default threads from textile
  - Removes thread init config that was only used for configuring the textile default thread ID, which this branch has already removed
- Setup better aliases for files, and set list commands as defaults for their parent, e.g.
  - `textile threads` -> `textile threads list`
  - `textile files` -> `textile files list` -> `textile files list thread`
  - `textile thread files` -> `textile files thread` -> `textile files list thread`
  - `textile block files` -> `textile files block` -> `textile files list block` -> `textile files list block list`
- Fixes fetching file content when only one file was in a block:
  - `textile files block <blockid> --index=0 --path=. --content` is now `textile files block get <blockid> --index=0 --path=. --content`
- Commands that add files now output more meaningful information
- `textile subscribe` is now `textile observe`, same behaviour, clearer name, b/c compat provided
  - and for the HTTP API `/subscribe` is now `/observe`, b/c compat provided
- `textile thread unsubscribe` is now `textile thread abandon`, same behaviour, clearer name, b/c compat provided
- `textile token create` is now `textile token add`, with b/c
- Some flags have been converted to arguments for consistency, new signatures are
  - `textile block list <thread>`
  - `textile chat <thread>`
  - `textile feed [<thread>]`
  - `textile file add <thread> [<path>]`
  - `textile init <account-seed>`
  - `textile invite create <thread>`
  - `textile message add <thread> <body>`
  - `textile message list [<thread>]`
  - `textile observe [<thread>]`
  - `textile thread peer <thread>`
  - `textile thread rename <thread> <name>`
  - `textile thread abandon <thread>`
  - `textile wallet create [<passphrase>]`
  - `textile wallet accounts <mnemonic> [<passphrase>]`
- Some flags have been renamed for terseness:
  - `--repo-path` changed to `--repo`
  - `--pin-code` changed to `--pin`
- `textile --help` is now more compact
- Next page output is now clearer on how to exit
- Improved the documentation for `textile init`, `textile account seed`, `textile wallet`, `textile wallet accounts`, `textile observe`, `textile thread abandon`
- Fix `textile contact rm` not working due to typo (regression from v0.2)
- Fix `textile files add` not accepting stdin (regression from v0.2)
- Fix wallet accounts being generated with the passphrase as the mnemonic (regression from v0.2)

## Merges

- ff6741b
- 941388e
- d1b37d3
- a20f4b4
- 18d61ce
- 37db65a
- 554cac3
- 60bd455
- d927b3b
- 3a946de
- f58fd8a
- 745a622
- 408e881
- 2f1a9a6
- b536108
- ecfd667
- 5db56c2
- f27fe44
- 7eeade4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant