Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Can't run textile wallet accounts any more #809

Closed
flyskywhy opened this issue Jun 6, 2019 · 5 comments · Fixed by #821
Closed

Can't run textile wallet accounts any more #809

flyskywhy opened this issue Jun 6, 2019 · 5 comments · Fixed by #821
Assignees
Labels
bug Something isn't working

Comments

@flyskywhy
Copy link
Contributor

Describe the bug
Can't run textile wallet accounts any more with version 0.2.2 and 0.2.3

To Reproduce
Steps to reproduce the behavior:

  1. Download go-textile_v0.2.3_linux-amd64.tar.gz from https://github.com/textileio/go-textile/releases
  2. Run textile wallet init to get SOME MNEMONIC PHRASE
  3. Run textile wallet accounts "SOME MNEMONIC PHRASE"
  4. See error textile: error: unexpected SOME MNEMONIC PHRASE, try --help

Expected behavior
some ACCOUNT's public key and secret seed

Additional context
version 0.1.11 is good at textile wallet accounts

@flyskywhy flyskywhy added the bug Something isn't working label Jun 6, 2019
@carsonfarmer
Copy link
Member

I think a recent change to our command line tools now requires an explicit -p or --password= flag. See textile wallet accounts --help for details. This may need to be updated in docs.

@balupton
Copy link
Contributor

balupton commented Jun 6, 2019

Could also be a regression. Looking into it now.

@balupton
Copy link
Contributor

balupton commented Jun 6, 2019

I don't think this is a regression, but having it as a flag is strange. Will change it to an argument.

@sanderpick
Copy link
Member

@balupton this must be related to the bug where accounts are minted with the passphrase instead of the mnemonic in versions 0.2.0 and above. Same as,

https://github.com/textileio/desktop/issues/41
https://github.com/textileio/desktop/issues/42

@balupton
Copy link
Contributor

balupton commented Jun 7, 2019

Already communicated elsewhere, but figured I would consolidate it here.

@balupton this must be related to the bug where accounts are minted with the passphrase instead of the mnemonic in versions 0.2.0 and above. Same as,

textileio/desktop#41
textileio/desktop#42

Those issues were due to unescaped quotes, and fixes are already landing.

The issue in this one is due to CLI args vs flags.

balupton added a commit that referenced this issue Jun 13, 2019
- Closes textileio/community#89
- Closes #783
- Closes #793
- Closes #794
- Closes #795
- Closes #797
- Closes #798
- Closes #799
- Closes #809
- Closes #812

## Internal changes:

- next page functionality moved to helper, and wording changed to be more clear

## User facing changes:

- Removed the concept of default threads from textile
  - Removes thread init config that was only used for configuring the textile default thread ID, which this branch has already removed
- Setup better aliases for files, and set list commands as defaults for their parent, e.g.
  - `textile threads` -> `textile threads list`
  - `textile files` -> `textile files list` -> `textile files list thread`
  - `textile thread files` -> `textile files thread` -> `textile files list thread`
  - `textile block files` -> `textile files block` -> `textile files list block` -> `textile files list block list`
- Fixes fetching file content when only one file was in a block:
  - `textile files block <blockid> --index=0 --path=. --content` is now `textile files block get <blockid> --index=0 --path=. --content`
- Commands that add files now output more meaningful information
- `textile subscribe` is now `textile observe`, same behaviour, clearer name, b/c compat provided
  - and for the HTTP API `/subscribe` is now `/observe`, b/c compat provided
- `textile thread unsubscribe` is now `textile thread abandon`, same behaviour, clearer name, b/c compat provided
- `textile token create` is now `textile token add`, with b/c
- Some flags have been converted to arguments for consistency, new signatures are
  - `textile block list <thread>`
  - `textile chat <thread>`
  - `textile feed [<thread>]`
  - `textile file add <thread> [<path>]`
  - `textile init <account-seed>`
  - `textile invite create <thread>`
  - `textile message add <thread> <body>`
  - `textile message list [<thread>]`
  - `textile observe [<thread>]`
  - `textile thread peer <thread>`
  - `textile thread rename <thread> <name>`
  - `textile thread abandon <thread>`
  - `textile wallet create [<passphrase>]`
  - `textile wallet accounts <mnemonic> [<passphrase>]`
- Some flags have been renamed for terseness:
  - `--repo-path` changed to `--repo`
  - `--pin-code` changed to `--pin`
- `textile --help` is now more compact
- Next page output is now clearer on how to exit
- Improved the documentation for `textile init`, `textile account seed`, `textile wallet`, `textile wallet accounts`, `textile observe`, `textile thread abandon`
- Fix `textile contact rm` not working due to typo (regression from v0.2)
- Fix `textile files add` not accepting stdin (regression from v0.2)
- Fix wallet accounts being generated with the passphrase as the mnemonic (regression from v0.2)

## Merges

- ff6741b
- 941388e
- d1b37d3
- a20f4b4
- 18d61ce
- 37db65a
- 554cac3
- 60bd455
- d927b3b
- 3a946de
- f58fd8a
- 745a622
- 408e881
- 2f1a9a6
- b536108
- ecfd667
- 5db56c2
- f27fe44
- 7eeade4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants