This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Pulls in provider records fix from go-ipfs master #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also binds the cafe API to 0.0.0.0 by default so that it's visible from a LAN IP. All in the name of less configuration.
sanderpick
requested review from
andrewxhill,
asutula,
balupton and
carsonfarmer
as code owners
|
This depends on ipfs/kubo#6289 |
|
Ok, ready for a look on this one even though it's referencing an un-merged go-ipfs PR. |
sanderpick
commented
May 2, 2019
sanderpick
commented
May 2, 2019
|
What do you all think about giving this a shot on the prod cafes? I'd like to see how it behaves even though there are likely other fixes coming. |
|
The autonat issue was merged. I'll pull that in now. |
asutula
approved these changes
May 2, 2019
sanderpick
added a commit
that referenced
this pull request
May 3, 2019
Pulls in provider records fix from go-ipfs master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the name of less configuration, also removes the
Cafe.Host.Localconfig flag in favor of the following:Fixes #716