Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Send invite on direct message #1166

Merged
merged 8 commits into from
Jun 29, 2019
Merged

Conversation

undercase
Copy link
Contributor

Fixes #1129. Features:

  • Extends CreateThreadModal to support configuration parameters (ThreadConfig).
  • Opens up a CreateThreadModal when creating a direct message thread so that the user can choose its initial name.
  • Sends an invite to the contact when a direct message thread is created.

…the direct message thread's name and an invite is sent.

Signed-off-by: Thomas Hobohm <public@thomashobohm.com>
Signed-off-by: Thomas Hobohm <public@thomashobohm.com>
andrewxhill
andrewxhill previously approved these changes Jun 18, 2019
Copy link
Member

@andrewxhill andrewxhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, some comments and some warns, up to you what you want with those @undercase

App/Components/CreateThreadModal.tsx Outdated Show resolved Hide resolved
App/Components/CreateThreadModal.tsx Outdated Show resolved Hide resolved
App/Containers/Contact.tsx Show resolved Hide resolved
App/Redux/PhotoViewingRedux.ts Outdated Show resolved Hide resolved
@asutula
Copy link
Member

asutula commented Jun 24, 2019

Sorry this one got a little stale. Let's get it updated, tests passing, and merged!

Signed-off-by: Thomas Hobohm <public@thomashobohm.com>
@undercase
Copy link
Contributor Author

@andrewxhill I removed the dependency on ThreadConfig in CreateThreadModal and it's no longer exported. This should be ready for further review & merge.

Copy link
Member

@asutula asutula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anywhere in here that an invite is being sent? Maybe just help me out and explain how/where that works. Thanks!

@undercase
Copy link
Contributor Author

@asutula CreateThreadModal will send invites once the user submits from that screen. I didn't manually add in the code to send an invite, I connected the button to CreateThreadModal, which handles it for me.

@undercase
Copy link
Contributor Author

Anything I can do to get this ready for merge?

@sanderpick
Copy link
Member

@asutula can we get this in? I think it's currently broken in the app when you "send a message", since no invite is sent and there is no way to add after the fact. My guess is this is a pretty common entry point to sharing since it's so intuitive.

@asutula
Copy link
Member

asutula commented Jun 28, 2019

Yea for sure. @undercase you want to get this thing up to date with master?

@undercase undercase merged commit e532243 into master Jun 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to sort out "send message" UX on the receiving end
4 participants