-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
…the direct message thread's name and an invite is sent. Signed-off-by: Thomas Hobohm <public@thomashobohm.com>
Signed-off-by: Thomas Hobohm <public@thomashobohm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, some comments and some warns, up to you what you want with those @undercase
Sorry this one got a little stale. Let's get it updated, tests passing, and merged! |
Signed-off-by: Thomas Hobohm <public@thomashobohm.com>
@andrewxhill I removed the dependency on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anywhere in here that an invite is being sent? Maybe just help me out and explain how/where that works. Thanks!
@asutula |
Anything I can do to get this ready for merge? |
@asutula can we get this in? I think it's currently broken in the app when you "send a message", since no invite is sent and there is no way to add after the fact. My guess is this is a pretty common entry point to sharing since it's so intuitive. |
Yea for sure. @undercase you want to get this thing up to date with master? |
Fixes #1129. Features:
CreateThreadModal
to support configuration parameters (ThreadConfig
).CreateThreadModal
when creating a direct message thread so that the user can choose its initial name.