fix(script-compiler): support node: prefix (#89)

* chore(deps): update textlint * test: add prh@6 test * fix(script-compiler): support node: prefix It just remove node: prefix from importing * add comment * CI: drop Node.js 16 support
textlint · Apr 3, 2024 · 985a49a · 985a49a
1 parent 9150d00
commit 985a49a
Show file tree

Hide file tree

Showing 11 changed files with 434 additions and 266 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [ 16,18 ]
+        node-version: [ 18, 20 ]
         os: [ ubuntu-latest, windows-latest ]
     steps:
       - name: checkout

diff --git a/packages/@textlint/config-inliner/package.json b/packages/@textlint/config-inliner/package.json
@@ -44,7 +44,7 @@
         "trailingComma": "none"
     },
     "dependencies": {
-        "@textlint/config-loader": "^13.3.0",
+        "@textlint/config-loader": "^14.0.4",
         "untildify": "^4.0.0"
     },
     "devDependencies": {

diff --git a/packages/@textlint/config-partial-parser/package.json b/packages/@textlint/config-partial-parser/package.json
@@ -44,10 +44,10 @@
         "trailingComma": "none"
     },
     "dependencies": {
-        "@textlint/config-loader": "^13.3.0",
-        "@textlint/kernel": "^13.3.0",
-        "@textlint/types": "^13.3.0",
-        "@textlint/utils": "^13.3.0"
+        "@textlint/config-loader": "^14.0.4",
+        "@textlint/kernel": "^14.0.4",
+        "@textlint/types": "^14.0.4",
+        "@textlint/utils": "^14.0.4"
     },
     "devDependencies": {
         "@types/mocha": "^10.0.1",

diff --git a/packages/@textlint/runtime-helper/package.json b/packages/@textlint/runtime-helper/package.json
@@ -40,11 +40,11 @@
     },
     "dependencies": {
         "@kvs/env": "^1.1.0",
-        "@textlint/config-loader": "^13.3.0",
-        "@textlint/kernel": "^13.3.0",
-        "@textlint/module-interop": "^13.3.0",
-        "@textlint/types": "^13.3.0",
-        "@textlint/utils": "^13.3.0"
+        "@textlint/config-loader": "^14.0.4",
+        "@textlint/kernel": "^14.0.4",
+        "@textlint/module-interop": "^14.0.4",
+        "@textlint/types": "^14.0.4",
+        "@textlint/utils": "^14.0.4"
     },
     "devDependencies": {
         "@types/mocha": "^10.0.1",

diff --git a/packages/@textlint/script-compiler/.textlintrc.json b/packages/@textlint/script-compiler/.textlintrc.json
@@ -1,6 +1,11 @@
 {
   "rules": {
     "no-dropping-the-ra": true,
-    "preset-ja-technical-writing": true
+    "preset-ja-technical-writing": true,
+    "prh": {
+      "rulePaths": [
+        "./prh.yml"
+      ]
+    }
   }
 }
diff --git a/packages/@textlint/script-compiler/package.json b/packages/@textlint/script-compiler/package.json
@@ -54,22 +54,22 @@
     "dependencies": {
         "@babel/core": "^7.12.10",
         "@textlint/config-inliner": "^0.16.0",
-        "@textlint/config-loader": "^13.3.0",
+        "@textlint/config-loader": "^14.0.4",
         "@textlint/config-partial-parser": "^0.16.0",
-        "@textlint/kernel": "^13.3.0",
+        "@textlint/kernel": "^14.0.4",
         "@textlint/runtime-helper": "^0.16.0",
         "@textlint/script-parser": "^0.16.0",
-        "@textlint/textlint-plugin-markdown": "^13.3.0",
-        "@textlint/textlint-plugin-text": "^13.3.0",
-        "@textlint/types": "^13.3.0",
+        "@textlint/textlint-plugin-markdown": "^14.0.4",
+        "@textlint/textlint-plugin-text": "^14.0.4",
+        "@textlint/types": "^14.0.4",
         "babel-loader": "^8.2.2",
         "babel-plugin-static-fs": "^3.0.0",
         "meow": "^9.0.0",
         "node-polyfill-webpack-plugin": "^2.0.1",
         "read-pkg": "^5.2.0",
         "rimraf": "^3.0.2",
         "terser-webpack-plugin": "^5.3.6",
-        "webpack": "^5.75.0"
+        "webpack": "^5.91.0"
     },
     "devDependencies": {
         "@types/mocha": "^10.0.1",
@@ -79,6 +79,7 @@
         "prettier": "^2.3.0",
         "textlint-rule-no-dropping-the-ra": "^3.0.0",
         "textlint-rule-preset-ja-technical-writing": "^6.0.0",
+        "textlint-rule-prh": "^6.0.0",
         "ts-node": "^10.9.1",
         "ts-node-test-register": "^10.0.0",
         "typescript": "^4.9.5"

diff --git a/packages/@textlint/script-compiler/prh.yml b/packages/@textlint/script-compiler/prh.yml
@@ -0,0 +1,3 @@
+version: 1
+rules:
+  - expected: jQuery
diff --git a/packages/@textlint/script-compiler/src/compiler.ts b/packages/@textlint/script-compiler/src/compiler.ts
@@ -91,6 +91,12 @@ export const createWebpackConfig = ({
             new webpack.BannerPlugin({
                 banner: `textlinteditor:@@@ ${JSON.stringify(metadata)} @@@`
             }),
+            // Remove the `node:` prefix
+            // see: https://github.com/webpack/webpack/issues/14166
+            // see: https://github.com/web-infra-dev/rsbuild/pull/1402
+            new webpack.NormalModuleReplacementPlugin(/^node:/, (resource) => {
+                resource.request = resource.request.replace(/^node:/, "");
+            }),
             // Node.js polyfill
             new NodePolyfillPlugin({})
         ],
@@ -193,7 +199,7 @@ export const compile = async (options: compileOptions) => {
                 config: rawConfig
             }
         });
-        webpack([config], (error: undefined | (Error & { details?: string }), stats?) => {
+        webpack([config], (error: null | (Error & { details?: string }), stats?) => {
             if (error) {
                 console.error(error.stack || error);
                 if (error.details) {

diff --git a/packages/textchecker-element/package.json b/packages/textchecker-element/package.json
@@ -68,7 +68,7 @@
         "vite": "^4.4.4"
     },
     "dependencies": {
-        "@textlint/source-code-fixer": "^13.3.0",
+        "@textlint/source-code-fixer": "^14.0.4",
         "eventmit": "^1.1.0",
         "lit-html": "^1.3.0",
         "p-debounce": "^2.1.0",

diff --git a/packages/webextension/package.json b/packages/webextension/package.json
@@ -28,9 +28,9 @@
         "@reach/router": "^1.3.4",
         "@react-stately/data": "^3.1.2",
         "@spectrum-icons/workflow": "^3.2.0",
-        "@textlint/config-loader": "^13.3.0",
+        "@textlint/config-loader": "^14.0.4",
         "@textlint/script-parser": "^0.16.0",
-        "@textlint/types": "^13.3.0",
+        "@textlint/types": "^14.0.4",
         "codemirror": "^5.59.2",
         "comlink": "^4.3.0",
         "comlink-extension": "^1.0.8",