Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(script-compiler): support node: prefix #89

Merged
merged 5 commits into from
Apr 3, 2024
Merged

fix(script-compiler): support node: prefix #89

merged 5 commits into from
Apr 3, 2024

Conversation

azu
Copy link
Member

@azu azu commented Apr 3, 2024

@azu azu linked an issue Apr 3, 2024 that may be closed by this pull request
@azu azu added Type: Bug Bug or Bug fixes Type: Breaking Change Includes breaking changes labels Apr 3, 2024
Comment on lines +94 to +99
// Remove the `node:` prefix
// see: https://github.com/webpack/webpack/issues/14166
// see: https://github.com/web-infra-dev/rsbuild/pull/1402
new webpack.NormalModuleReplacementPlugin(/^node:/, (resource) => {
resource.request = resource.request.replace(/^node:/, "");
}),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix #88

Comment on lines +4 to +9
"preset-ja-technical-writing": true,
"prh": {
"rulePaths": [
"./prh.yml"
]
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add prh as test

@azu azu merged commit 985a49a into master Apr 3, 2024
9 checks passed
@azu azu deleted the feature/88 branch April 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Includes breaking changes Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[script-compiler] compile error with textlint-rule-prh
1 participant