[WIP] feat(textlint-tester): implement snapshot testing #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
commented
Aug 7, 2018
|
|
||
| ` | ||
|
|
||
| exports['123_345 1'] = ` |
There was a problem hiding this comment.
We should define what snapshot output format.
- Input
- (Optional) Output
- (Optional) Lint Message for human
azu
commented
Aug 7, 2018
| const inputPath = typeof state === "object" ? state.inputPath : undefined; | ||
| const ext = typeof state === "object" && state.ext !== undefined ? state.ext : ".md"; | ||
| const singleName = text.split(/\n/g).join("_"); | ||
| it(text || inputPath || "NO name", () => { |
There was a problem hiding this comment.
TODO: should support inputPath correctly
|
It will change rule test flow. Current:
Snapshot:
|
|
Anothor option: user can specify file name per test case. tester.run(rule, {
snapshots: {
"filename.txt": { text: "string" }
}
}); |
A workaround for bahmutov/snap-shot-core#117 But, it is not working all case
azu
force-pushed
the
textlint-tester-snapshot
branch
from
1e17185
to
0b54591
Compare
|
Blocker: bahmutov/snap-shot-core#195 |
|
I'll separate this snapshot testing as other testing library. Because, we need to try it and get error before merging snapshot testing. |
|
Close this. We will implement this based on secretlint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC: implement snapshot testing using snap-shot-core
It includes very hacky way for bahmutov/snap-shot-core#51
process.chdiris bad...fix #542