fix(util): exportText treat text as template string #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
commented
Dec 30, 2018
| return `exports['${name}'] = \`${withNewLines}\`\n` | ||
| // jsesc replace "\n" with "\\n" | ||
| // https://github.com/mathiasbynens/jsesc/issues/20 | ||
| const serialized = value.split('\n').map(line => { |
There was a problem hiding this comment.
jsesc does replace \\n with \n.
azu
commented
Dec 30, 2018
| it('does escape template variable on the text', () => { | ||
| /* eslint-disable no-template-curly-in-string */ | ||
| const formatted = exportText('name', '`${1}`') | ||
| const expected = "exports['name'] = `\n\\`\\${1}\\`\n`\n" |
There was a problem hiding this comment.
I also test following code is work.
var exports = {};
eval("exports['name'] = `\n\\`\\${1}\\`\n`\n")
escape text by jsesc
azu
force-pushed
the
fix-serialize-template-string
branch
from
9ffb7c7
to
7c404c5
Compare
|
/cc @bahmutov @krzkaczor |
|
This PR looks good, it would be nice to see it merged, so I can strip out my workarounds. |
|
🎉 This PR is included in version 7.1.13 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
escape text by jsesc.
jsescsupportquote: "backtick".fix #117