Remove unused methods. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#to_html` is used only once in `#preview`, and `#preview` isn’t used anywhere at all (I searched across the complete bundle source code, including commands.) I stumbled upon this because `#to_html` in this bundle is the only place still referring to `lib/bluecloth.rb` from the bundle support bundle. After we get rid of this here, we can then get rid of `bluecloth.rb`.
Seems like `#post` and `#update` (amongst others) were originally copied from the “Blogging” bundle, but there are no commands here actually using them. `#show_post_page` is only used by `#post` and `#update`. Removing this (dead) code here means that `lib/browser` from bundle support is then only used by the blogging bundle and can be moved from bundle support into that bundle.
|
Looked at the commands in question and they really just seemed to serve no real purpose. I've just removed them and the accompanying libraries entirely. Problem solved. :) |
infininight
pushed a commit
to textmate/bundle-support.tmbundle
that referenced
this pull request
Aug 29, 2016
Not used anywhere. And bundles that want to render Markdown should use `TextMate::Markdown.to_html` anyway (which uses Markdown.pl internally). Also see textmate/typo3.tmbundle#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#to_htmlis used only once in#preview, and#previewisn’t used anywhere at all (I searched across the complete bundle source code, including commands.)I stumbled upon this because
#to_htmlin this bundle is the only place still referring tolib/bluecloth.rbfrom the bundle support bundle. After we get rid of this here, we can then get rid ofbluecloth.rb.