Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme enhancement (native oui_flat like support) #1196

Closed
HashandSalt opened this issue Mar 16, 2018 · 10 comments
Closed

Theme enhancement (native oui_flat like support) #1196

HashandSalt opened this issue Mar 16, 2018 · 10 comments

Comments

@HashandSalt
Copy link

I am requesting and putting up for discussion the idea that the new theme support could be greatly enhanced if it was possible to edit the flat files on the file system and have them updated on a browser reload rather than having to manually force a them update or a use a webhook to update the theme code. This approach is much faster during development.

@NicolasGraph
Copy link

NicolasGraph commented Mar 16, 2018

I feel like it is a plug-in area but I don't really know. Anyway I won't be able to do it for this release. 4.8?

@bloatware
Copy link
Member

bloatware commented Mar 16, 2018

It shouldn't be too difficult to fetch themes directly from flat files, but it will take some time to test. Not in beta-2 anyway.

@bloatware
Copy link
Member

Something to test.

@HashandSalt
Copy link
Author

Ok, Some preliminary notes:

  • Works great if you are logged in and viewing the local domain directly and you manually refresh the browser
  • Does not work with Browserync via proxy, because it does not trigger a full page refresh when the theme files are changed. Reading the browsersync docs, it suggests it should do a full refresh if the file change is not a CSS or Javascript file.
  • Reloading the the proxied browsersynced site only picks up content changed, NOT theme changes (which is bizarre).

I'll keep testing to see if i can get browsersync to do a full reload. I think some of these issues are down the way i usually use browsersync. Maybe TXP cant tell im logged in because viewing via browsersyncs built in proxy.

@philwareham philwareham added this to the v4.7 milestone Apr 30, 2018
@bloatware bloatware modified the milestones: v4.7, v4.7.1 May 7, 2018
@bloatware bloatware modified the milestones: v4.7.1, v4.7.2 May 16, 2018
@Bloke Bloke mentioned this issue Oct 9, 2018
8 tasks
@philwareham
Copy link
Member

Is this OK to close? Further enhancements can be made during the 4.8 dev cycle now I think (things such as URL hooks and/or working directly on flat files when in testing mode in core instead of as a plugin). Let me know. We can then look at releasing 4.7.2 in coming days and concentrate on all the 4.8 goodness we've planned.

@Bloke
Copy link
Member

Bloke commented Dec 6, 2018

I'm happy to close this for now. The plugin suffices until such time as we figure out something in core.

@HashandSalt
Copy link
Author

@philwareham Fine by me :)

@bloatware
Copy link
Member

I'm still unsure for the workflow and wouldn't like to do it in a rush. Progressively amending the plugin looks more reasonable atm.

@bloatware bloatware modified the milestones: v4.7.2, v4.8 Dec 7, 2018
@philwareham
Copy link
Member

Yep, agreed!

@petecooper petecooper changed the title 4.7-beta theme enhancement (native oui_flat like support) Theme enhancement (native oui_flat like support) Feb 26, 2019
@petecooper petecooper modified the milestones: v4.8, v4.10, v4.9 Nov 28, 2019
@philwareham
Copy link
Member

philwareham commented Feb 28, 2020

The original scope of this issue has been addresses now. Theme handling from here on is for iterative improvements and doesn't need a specific issue open for it. Closing - cheers everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants