New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme enhancement (native oui_flat like support) #1196
Comments
I feel like it is a plug-in area but I don't really know. Anyway I won't be able to do it for this release. 4.8? |
It shouldn't be too difficult to fetch themes directly from flat files, but it will take some time to test. Not in beta-2 anyway. |
Something to test. |
Ok, Some preliminary notes:
I'll keep testing to see if i can get browsersync to do a full reload. I think some of these issues are down the way i usually use browsersync. Maybe TXP cant tell im logged in because viewing via browsersyncs built in proxy. |
Is this OK to close? Further enhancements can be made during the 4.8 dev cycle now I think (things such as URL hooks and/or working directly on flat files when in testing mode in core instead of as a plugin). Let me know. We can then look at releasing 4.7.2 in coming days and concentrate on all the 4.8 goodness we've planned. |
I'm happy to close this for now. The plugin suffices until such time as we figure out something in core. |
@philwareham Fine by me :) |
I'm still unsure for the workflow and wouldn't like to do it in a rush. Progressively amending the plugin looks more reasonable atm. |
Yep, agreed! |
The original scope of this issue has been addresses now. Theme handling from here on is for iterative improvements and doesn't need a specific issue open for it. Closing - cheers everyone! |
I am requesting and putting up for discussion the idea that the new theme support could be greatly enhanced if it was possible to edit the flat files on the file system and have them updated on a browser reload rather than having to manually force a them update or a use a webhook to update the theme code. This approach is much faster during development.
The text was updated successfully, but these errors were encountered: