Write panel: Odd behaviour of the sub-panels in the sidebar on saving

[phiw13]

I’m not sure if I should blame @philwareham [1] or @bloatware [2] for this.

STR:

1. open an existing article
2. observe the state of the sidebar (for ease of testing: all sub panels in the sidebar are closed/collapsed)
3. edit the article – any type of editing will do (edit text, change status,…)
4. save
5. observe the state of the sidebar. On my Mac (tested with Safari and Firefox dev. edition), the “recent articles” sub panel is now open (and this can not be changed unless leaving the Write panel and returning – or toggling the view Text --> HTML and back) and the “comment” sub panel is open, but its heading is not displayed (again, toggling the view is enough to restore some sanity).

But open another article for editing or create a new article and the sub panels return to the state they were. Note also that this does not happen when creating a new article.

[1] f0fb17f
[2] ff1a211

Screenshot of the comment sub panel:

[phiw13]

Thanks @rwetzlmayr.
Mostly there – I still see a small glitch in the Comment sub panel. After saving an existing article, there are 2 “Invitation” fields. As before, switching back-and-forth between views restores things to a sane state.

[philwareham]

I have no idea why this is happening, sorry - tried a couple of placeholder variations but to no avail. Hopefully @rwetzlmayr can fix it for us.

[rwetzlmayr]

@philwareham The panel would need a single embracing HTML element as a parent for the .comment-annotate and .comment-invite elements as the AJAX update request needs one single unique CSS selector to update the panel's content.

Please suggest a proper markup, I'll patch it in.

[philwareham]

@rwetzlmayr OK, would the wrapper have to wrap the potential 'Comments expired' paragraph too, or is that not necessary?

[rwetzlmayr]

@philwareham No, they needn't. We just need a common selector for both the 'comments are open' and 'comments are expired' states of that markup.

Which makes me wonder whether fieldset is still en vogue these days...