This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Adds Emoji classifier using Doc.match #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dodijk
force-pushed
the
feature/spacy-matcher
branch
from
561568b
to
efd3a10
Compare
dodijk
force-pushed
the
feature/emoji
branch
3 times, most recently
from
cf94a52
to
b3f21a8
Compare
dodijk
changed the title
anneschuth
approved these changes
Aug 29, 2018
graus
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
I don't have a strong opinion. I suppose having this data in a more 'general purpose/standardized'-format (e.g., .csv or something standard) would be nice, with adding a function to read it.
But, I presume your scan of related packages means this is fine too. Not too bothered either way!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a matcher for emojis with sentiment scores.
Open for debate is how to work with a dataset like we do in this PR. Based on a quick round of related packages, my proposal is to include those in
textpipe/data/*.pyfiles.