fixing placement names for local testing and remote execution. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mortendahl
force-pushed
the
docker-fixes
branch
from
3f69f2d
to
f8eb4d7
Compare
mortendahl
reviewed
Oct 2, 2020
examples/python-functions/main.py
Outdated
| inputter1: runtime.executors[1], | ||
| aggregator: runtime.executors[2], | ||
| outputter: runtime.executors[3], | ||
| placement: runtime.executors[placement.name] |
There was a problem hiding this comment.
sorry, I think it was better before then, ie without the all_placements :D
mortendahl
reviewed
Oct 2, 2020
moose/executor/executor_test.py
Outdated
| placement_assignment = { | ||
| players[i]: runtime.executors[i] for i in range(len(players)) | ||
| players[i]: runtime.executors[players[i].name] for i in range(len(players)) |
There was a problem hiding this comment.
this could be rewritten as player: runtime.executors[player.name] for player in players
mortendahl
approved these changes
Oct 2, 2020
|
think I've fixed everything, but can we keep the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.