SeCommon - RFC #25
Open
SeCommon - RFC #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinkoz
commented
Jan 20, 2015
dinkoz
commented
- TODO : add missing actions to server
- How to create Session?
- What about FF preferences?
- SessionContext should be argument with which session is created (??)
- TODO : add missing actions to server - How to create Session? - What about FF preferences? - SessionContext should be argument with which session is created (??)
| return t; | ||
| } | ||
|
|
||
| public static <T> List<T> guardEmptyList(final List<T> tList, final String field) { |
There was a problem hiding this comment.
Can we add a guard against null elements here (foreach element guardNull)?
Also add another guard for lists which checks every elements for nulls, but doesn't check emptyness (or add an argument for that here).
There was a problem hiding this comment.
Throw exception on null element. There is no excuse for having null elements in lists.
removed some object mutation functions there are some cases where you want to change (update) only certain property's like in the case of ElementSelector when you want tu se existing but with different UUID and INDEX
Conflicts: code/Common/src/main/java/net/selenate/common/comms/SeElementSelector.java code/project/Settings.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.