Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract method from duplicate code in dnn #1010

Merged
merged 3 commits into from
Feb 11, 2018
Merged

Extract method from duplicate code in dnn #1010

merged 3 commits into from
Feb 11, 2018

Conversation

selcouthlyBlue
Copy link
Contributor

No description provided.

@selcouthlyBlue
Renamed tflearn.losses to regularizers.
dccaf82 
The functions within the renamed module are not losses but regularizers.
@selcouthlyBlue
Replaced logging.warn with logging.warning.
0afda47 
Logging.warn is now deprecated.
@selcouthlyBlue
Extracted method from duplicate code in dnn.py.
d623acf
aymericdamien
aymericdamien approved these changes Feb 11, 2018
View reviewed changes
Copy link
Member

@aymericdamien aymericdamien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I agree that it makes more sense to rename the 'losses' file to 'regularizers'. I will merge your changes.

@aymericdamien aymericdamien merged commit 70fb38a into tflearn:master Feb 11, 2018
@selcouthlyBlue selcouthlyBlue deleted the extract_duplicate_code_in_dnn branch February 11, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymericdamien aymericdamien aymericdamien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@selcouthlyBlue @aymericdamien