Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve to_categorical function #923

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Improve to_categorical function #923

merged 2 commits into from
Oct 19, 2017

Conversation

herossa
Copy link
Contributor

@herossa herossa commented Oct 5, 2017 •
edited
Loading

nb_classes not required anymore
thanks @fabiodosreis2

@herossa
Improve to_categorical function
9b91328 
nb_classes not required anymore
aymericdamien
aymericdamien reviewed Oct 18, 2017
View reviewed changes
Copy link
Member

@aymericdamien aymericdamien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review! This sounds great, thanks for simplifying that. Can you also update the various examples that are using that function - to avoid them from being broken?

@herossa
Copy link
Contributor Author

herossa commented Oct 18, 2017

Done

aymericdamien
aymericdamien approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@aymericdamien aymericdamien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@aymericdamien aymericdamien merged commit 2f5853c into tflearn:master Oct 19, 2017
@jamescorbett jamescorbett mentioned this pull request Oct 29, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymericdamien aymericdamien aymericdamien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herossa @aymericdamien