Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No versions matching 'min-required' found in remote #231

Closed
jrobison-sb opened this issue Jan 31, 2021 · 6 comments
Closed

No versions matching 'min-required' found in remote #231

jrobison-sb opened this issue Jan 31, 2021 · 6 comments
Labels

Comments

@jrobison-sb
Copy link

jrobison-sb commented Jan 31, 2021

Steps to reproduce:

docker run -it --rm ubuntu:20.04
apt-get update && apt-get install -y git curl unzip
git clone https://github.com/tfutils/tfenv.git ~/.tfenv
export PATH="$HOME/.tfenv/bin:$PATH"

cd /your/terraform/directory
cat backend.tf

terraform {
  required_version = "= 0.13.5"
}


tfenv install min-required

No versions matching 'min-required' found in remote

Prior to 2.1 this was working as expected. And FWIW tfenv list-remote does list 0.13.5 as being available.

@Zordrak Zordrak added the bug label Feb 1, 2021
@Zordrak
Copy link
Collaborator

Zordrak commented Feb 1, 2021

I've never actually worked on min-required myself, I don't have any use for it, it's been implemented and extended by others - so I'm less than perfectly familiar with it, but I can reproduce, and in fact worse because after failing to find a matching version it continues to try to download with an empty version string.

Looking into it as time allows to see what I can work out here.

@Zordrak
Copy link
Collaborator

Zordrak commented Feb 1, 2021

@mrpaws Any input you have on this would be welcomed.

@Zordrak
Copy link
Collaborator

Zordrak commented Feb 1, 2021

v2.0.0

$ /opt/tfenv/libexec/tfenv-min-required
0.13.5

v2.1.0

$ /opt/tfenv/libexec/tfenv-min-required
= 0.13.5

All indications point to the tag-support implemented with #206

@Zordrak
Copy link
Collaborator

Zordrak commented Feb 1, 2021

Also, the test suite clearly fails - I don't know how this wasn't picked up during my best-effort pre-release testing, that's on me.

@tskinn
Copy link
Contributor

tskinn commented Feb 3, 2021

It seems to me that this change #203 broke the min-required functionality. From some brief testing I think this fixes it. #235

@Zordrak
Copy link
Collaborator

Zordrak commented Feb 6, 2021

Cracking job, thanks.
I have now migrated testing from Travis CI to GitHub Actions. Hopefully we're back on track.

@Zordrak Zordrak closed this as completed Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants