Update tfenv-min-required grep logic to prefer working root directory declarations first before recursing. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposing that tfenv 'min-required' only first searches the working directory first, before recursing. This prevents unexpected version matches in cases where path based child modules might have their own required_version blocks. Since terraform itself first parses the base directory, it would seem reasonable tfenv would follow suit.
|
Sorry for that commit message length, it was a small change and I did it via github visual editor and realized right after what I'd done. |
Zordrak
previously approved these changes
Jan 30, 2021
Zordrak
approved these changes
Jan 30, 2021
This was referenced Feb 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing that tfenv 'min-required' first searches the working directory before recursing.
In this case if the first grep does not return exit code 0,
||operator will instead rungrep -Rand keep searchingThis prevents unexpected version matches in cases where path based child modules might have their own required_version blocks. Since terraform itself first parses the base directory, it would seem reasonable tfenv would follow suit.