New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do no dispose of httpclient after each call. #23

Merged

tghamm merged 2 commits into tghamm:main from gluip:bugfix/do_not_dispose_custom_client

Apr 12, 2024

Contributor

gluip commented Apr 12, 2024 •

edited

Loading

@tghamm I get a disposed object exception after the first call using a custom HttpClient. I added a test demonstrating the issue. This is a fix

gluip added 2 commits

April 12, 2024 15:03


          Do no dispose of httpclient after each call.

964eaad


          Fix test name

e5a65cd

Owner

tghamm commented Apr 12, 2024

Whoops! Thank you @gluip Will review here in a moment and get a patch out assuming things check out.

tghamm merged commit 04ea88a into tghamm:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment