refactor user service #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2020
Closed
|
@kunwar97 Dang! You resolved #20, but I think there's a problem with the issue itself! I forgot that these endpoints need to generate and return a token, and generating a token is neither the job of a controller nor of a repository, so it must be the job of a separate service layer. Does that make sense? I'll update the issue ASAP. Meanwhile, there are still some good changes I would like to merge from this PR. In particular,
If you copy back all of |
|
@tgiardina sure |
|
I'm trying to refactor things so that I don't need |
|
Pushed this through. Thanks @kunwar97! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.