Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings editor may need I/O operation to apply settings, and should use the async way.
This PR add a method ApplyChangesAsync in a specific ISettingsEditorAsync interface.
Existing interface is kept to avoid breaking changes.
Implementation have been done in a binary backward compatible way for implementations of ISettingsEditor (as they may come from a NuGet that might not be possible to rebuild).
A breaking change have been made SettingsPageViewModel.Editors (only used by View/Xaml file), no one on github have a an access to SettingsPageViewModel, so it seems a safe change.