Fix error with CLI trying to select environment config for "basic configuration" #1101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Per the docs for CLI knexfile.js, the following configuration should be supported:
Per the following conditional block in
/src/bin/cli.js#L56-L59
(introduced in #527) there is no check to make sureconfig[environment]
exists.This results in an undefined config when using the basic configuration.
Pull Request Details
This pull request includes:
config
assignment defaults to itself whenconfig[environment]
does not existNODE_ENV
is also used to set the environment in Knex CLI(this was my issue originally…I did not know the CLI environment defaults to
NODE_ENV
)NOTE: I branched off
master
, but after following the CONTRIBUTING guidelines other files inlib
showed changes after building that my code would not have affected. My assumption is that the latest build inmaster
was dirty so I have only included src changes in this PR.